Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-9281] Bar charts with no labels or borders fail non-text contrast #1838

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

khartco
Copy link
Collaborator

@khartco khartco commented Jan 14, 2025

[DEV-9281]

Bar chart labels and outline enabled by default, add tooltips recommending to remain enabled.

Testing Steps

  • Create a new bar chart or use a config that does not specify barHasBorder or labels (boolean)
    • Bar chart should have border and text labels by default
  • Check editor for both options for tooltip that recommends the options be enabled

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

Screenshots (if applicable)

n/a

Additional Notes

n/a

Copy link
Collaborator

@adamdoe adamdoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Nice!

@adamdoe adamdoe merged commit 05b45ee into dev Jan 15, 2025
1 check passed
@adamdoe adamdoe deleted the feature/DEV-9281 branch January 15, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants